Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smwgDefaultLoggerRole #2933

Merged
merged 1 commit into from Jan 6, 2018
Merged

Add smwgDefaultLoggerRole #2933

merged 1 commit into from Jan 6, 2018

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Jan 6, 2018

This PR is made in reference to: #

This PR addresses or contains:

  • Adds the smwgDefaultLoggerRole admin setting to filter the amount (in terms of granularity) of information being logged when either $wgDebugLogFile or $wgDebugLogGroups is enabled
  • The default role is set to $GLOBALS['smwgDefaultLoggerRole'] = 'production' which means that only a very limited log output is generated, to show all SMW related loggable events the developer role is required, the user role will include extra events such executions of jobs
  • Use LoggerAwareTrait more consistently instead of implements LoggerAwareInterface

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #

@mwjames mwjames added this to the SMW 3.0.0 milestone Jan 6, 2018
@mwjames
Copy link
Contributor Author

mwjames commented Jan 6, 2018

@kghbln By default this should minimize the log spam produced by SMW with the [smw] identifier. The next time we require some in-depth analysis, you most likely need to change the role setting to developer.

@mwjames mwjames merged commit 980b1f5 into master Jan 6, 2018
@mwjames mwjames deleted the logger branch January 6, 2018 06:31
@kghbln kghbln added enhancement Alters an existing functionality or behaviour wikidocu missing Code changes (mostly features) what have not yet been documented labels Jan 6, 2018
mwjames added a commit that referenced this pull request Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Alters an existing functionality or behaviour wikidocu missing Code changes (mostly features) what have not yet been documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants