Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use html format for _eid types in a reference, refs 2985 #2986

Merged
merged 1 commit into from Feb 3, 2018

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

commented Feb 3, 2018

This PR is made in reference to: #2985

This PR addresses or contains:

  • When building a reference list, formatting of values need to be cared for to ensure that raw wikitext (either as [ ...] or [[ ... ]] and in which case of the _eid type was [https://www.wikidata.org/entity/...] caused a double parse and ultimately broke the link representation) is transformed before embedded in the outer content representation

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #2985

@kghbln kghbln added this to the SMW 3.0.0 milestone Feb 3, 2018

@mwjames mwjames merged commit a121122 into master Feb 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the ref-eid branch Feb 3, 2018

@kghbln

This comment has been minimized.

Copy link
Member

commented Feb 3, 2018

This could probably be backported?

@mwjames

This comment has been minimized.

Copy link
Contributor Author

commented Feb 3, 2018

This could probably be backported?

The change is only one line and the test should work on 2.5.+ as well, so if you think it is worth it, feel free.

kghbln added a commit that referenced this pull request Feb 3, 2018

@kghbln kghbln modified the milestones: SMW 3.0.0, SMW 2.5.6 Feb 3, 2018

@kghbln

This comment has been minimized.

Copy link
Member

commented Feb 3, 2018

Back-ported with 9a8d1c8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.