New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `smwgCompactLinkSupport` #3017

Merged
merged 1 commit into from Feb 18, 2018

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

mwjames commented Feb 17, 2018

This PR is made in reference to: #

This PR addresses or contains:

  • Adds $smwgCompactLinkSupport setting (default: true) to generate "compact" (aka base64) links for pages like Special:Ask, Special:Browse, and Special:SearchByProperty
  • Links will be similar to something like Special:Browse/cl:OkV4YW1wbGUtMkZTMDAyNA and depending on the size of the query string (especially for Special:Ask links) some space saving can be considered but is not the main objective
    • Special:Ask/-5B-5BProperty:%2B-5D-5D-20-5B-5BCategory:Lorem-20ipsum-5D-5D/-3FHas-20description%3DDescription/-3FHas-20type/mainlabel%3D/limit%3D50/offset%3D50/format%3Dtable/class%3Ddatatable
    • Special:Ask/cl:YzpFirEKwzAMRD-oGIcWLwEvaSgdOvQXlEQuAjsykjLk75u6Q-CGd-_OhcGF4S1cUWzvLy6Mv1w714Y7GH5Y9v7FguXQVHUr_5N3t8cT9JAL6ixUjXiN48nnwfaKvgCtGSbM0WcqZDF0nlNSbJRYClg0mDL6OYNqXMCg9S8

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #

@mwjames mwjames added the enhancement label Feb 17, 2018

@mwjames mwjames added this to the SMW 3.0.0 milestone Feb 17, 2018

@mwjames mwjames merged commit e10bc72 into master Feb 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the compact-link branch Feb 18, 2018

mwjames added a commit that referenced this pull request Apr 14, 2018

@mwjames mwjames referenced this pull request Sep 1, 2018

Merged

Handle compact links for long titles, refs 3017 #3378

1 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment