Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replace of `smw_proptable_hash` during setup #3026

Merged
merged 1 commit into from Feb 24, 2018

Conversation

@mwjames
Copy link
Contributor

mwjames commented Feb 24, 2018

This PR is made in reference to: #

This PR addresses or contains:

  • The issue is in existence at least since [0] where during the setup predefined properties are replaced but if those would have a page with additional annotations (category etc.) then there would vanish because the smw_proptable_hash reference was reset during the replace action

[0] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/1.8.0.5/includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php#L246-L263

This PR includes:

  • Tests (unit/integration)
  • CI build passed
@mwjames mwjames added this to the SMW 3.0.0 milestone Feb 24, 2018
@mwjames mwjames merged commit 9dbec72 into master Feb 24, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mwjames mwjames deleted the pre-hash branch Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.