Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `SMW::LinksUpdate::ApprovedUpdate`, `SMW::Parser::ChangeRevision` hook #3032

Merged
merged 1 commit into from Feb 24, 2018

Conversation

@mwjames
Copy link
Contributor

mwjames commented Feb 24, 2018

This PR is made in reference to: https://sourceforge.net/p/semediawiki/mailman/message/36228453/

This PR addresses or contains:

  • Adds SMW::LinksUpdate::ApprovedUpdate, SMW::Parser::ChangeRevision hooks to influence which updates (and hereby revision) can be used in SMW.

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Notes

Also note that I'm using ApprovedRevs. I assumed that it wasn't returning
the values that are on unapproved pages. However, that isn't the case.

SMW doesn't depend or check for an approved revision from any of the available extensions including Extension:FlaggedRevs, Extension:Moderation, or Extension:Approved Revs during the LinksUpdateConstructed hook execution. If a third-party extension stores revision information in a different form or table which is not part of the LinksUpdateConstructed interface then SMW cannot use those information during its data validation phase.

Yet, to improve the situation for users that rely on those extensions and want to reflect the state of an approved status within SMW approve.update.md contains an example on how to facilitate the newly added hooks.

@mwjames mwjames added this to the SMW 3.0.0 milestone Feb 24, 2018
@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented Feb 24, 2018

@kghbln @hexmode @jamesmontalvo3 I know you guys worked with some of the listed extensions and to help enterprise user to better implement an integration for some of them, approve.update.md provides an example on how to do that.

As noted in the approve.update.md, if you use one of the hooks, please make sure to log the activity to avoid arbitrarily changing revisions where SMW expects the latest available as basis for the update process.

@mwjames mwjames merged commit 905f03e into master Feb 24, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mwjames mwjames deleted the linksupdate-hook branch Feb 24, 2018
@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented Feb 24, 2019

@mwjames mwjames mentioned this pull request Mar 16, 2019
1 of 2 tasks complete
@mwjames mwjames mentioned this pull request Apr 6, 2019
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.