New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List format rework #3130

Merged
merged 20 commits into from Apr 21, 2018

Conversation

Projects
None yet
3 participants
@s7eph4n
Copy link
Contributor

s7eph4n commented Apr 21, 2018

This PR is made in reference to: #2488

This PR addresses or contains:

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #2488

s7eph4n added some commits Jul 18, 2017

Mark all integration tests involving list format as incomplete; ...
+ Fix test f-0401
+ Improve error message of HtmlValidator
Add template handling
+ more clean-up
Test intro-/outrotemplate, links, headers; Improve parser-html tester…
…; i18n qqq-docs

+ some fixes for i18n, ol start, ...
Re-activate integration tests; add 'plainlist' format
+ loads of other stuff resulting from re-activation of tests
Clean up list format tests
* Add test case for plainlist
* Fix test case identifiers (f-401 => f-402)
* Cut down number of test pages (10 is plenty)
@mwjames

This comment has been minimized.

Copy link
Contributor

mwjames commented Apr 21, 2018

I haven't found any major glitches on the quick review I did. Any issues can be fixed in a follow-up and might be easier to spot hereafter.

I'm guessing the most problematic will be the switch from template parameter userparam to #userparam where I can see that it is used by people to import arbitrary data into a template and now be surprised that it no longer returns expected results BUT this work will be part of a major release so we are allowed to make that kind of change(s). [0] contains information about how to migrate and switch templates and related formats to conform with 3.0.

[0] https://gist.github.com/s7eph4n/277e7804fe04954df7d1e15ae874b0d0

@mwjames mwjames merged commit a42bbc7 into master Apr 21, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the listFormatRework branch Apr 21, 2018

@JeroenDeDauw JeroenDeDauw referenced this pull request Apr 22, 2018

Closed

3.0.0 release #1365

58 of 58 tasks complete
@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Apr 22, 2018

The biggest thing now will be to document on wiki and to create migration help.

mwjames added a commit that referenced this pull request Jul 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment