Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of deprecated wfBCP47() global function #3176

Merged
merged 1 commit into from Jul 3, 2018

Conversation

Projects
None yet
3 participants
@cscott
Copy link
Contributor

cscott commented Jun 26, 2018

This function was deprecated in MW 1.31 and is slated to be hard-deprecated in MW 1.32.

@JeroenDeDauw
Copy link
Member

JeroenDeDauw left a comment

Thanks for the patch. The next release of SMW will support MediaWiki 1.27 and above. Hence we cannot make the code require MediaWiki 1.31.

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jun 27, 2018

I just created an issue to track this. I guess it will be great to have a patch that works with MW 1.27 (LTS) and later as well as MW 1.31 (LTS) and later. I dunno if this is easy to do.

@cscott cscott force-pushed the cscott:deprecate-wfbcp47 branch 2 times, most recently from 2e98754 to 43c40e2 Jun 29, 2018

@cscott

This comment has been minimized.

Copy link
Contributor Author

cscott commented Jun 29, 2018

Amended the patch to be backwards compatible with MW < 1.31.

@JeroenDeDauw

This comment has been minimized.

Copy link
Member

JeroenDeDauw commented Jun 30, 2018

Tests failing and the stuff on master seems to work fine: https://github.com/SemanticMediaWiki/SemanticMediaWiki/commits/master

Perhaps rebasing fixes the issue

@cscott cscott force-pushed the cscott:deprecate-wfbcp47 branch from 43c40e2 to 6c377cd Jul 3, 2018

@cscott

This comment has been minimized.

Copy link
Contributor Author

cscott commented Jul 3, 2018

Rebased. Fingers crossed Travis is happy.

@cscott cscott force-pushed the cscott:deprecate-wfbcp47 branch from 6c377cd to c624fbe Jul 3, 2018

@cscott

This comment has been minimized.

Copy link
Contributor Author

cscott commented Jul 3, 2018

@JeroenDeDauw

This comment has been minimized.

Copy link
Member

JeroenDeDauw commented Jul 3, 2018

Thanks a lot @cscott !

@JeroenDeDauw JeroenDeDauw merged commit 775811b into SemanticMediaWiki:master Jul 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

JeroenDeDauw added a commit that referenced this pull request Jul 3, 2018

@kghbln kghbln added this to the SMW 3.0.0 milestone Jul 4, 2018

kghbln added a commit that referenced this pull request Jul 4, 2018

@kghbln kghbln modified the milestones: SMW 3.0.0, SMW 2.5.7 Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.