Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special:Admin switch to horizontal tabs, refs 2595, 3216 #3218

Merged
merged 1 commit into from Jul 15, 2018
Merged

Conversation

@mwjames
Copy link
Contributor

mwjames commented Jul 15, 2018

This PR is made in reference to: #2595, #3216

This PR addresses or contains:

  • Switches tabs from vertical to horizontal

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Example

image

@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented Jul 15, 2018

@kghbln Slight visual change from before plus the overview contains now all environment settings we expect for issue reporting, so users can just copy-and-paste the JSON formatted output such as:

{
    "SMWElasticStore": {
        "mysql": "10.1.21-MariaDB",
        "es": "6.2.4"
    },
    "smw": "3.0.0-alpha",
    "mediawiki": "1.30.0",
    "php": "7.1.1"
}
@kghbln kghbln added this to the SMW 3.0.0 milestone Jul 15, 2018
@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jul 15, 2018

Slight visual change from before plus the overview contains now all environment settings we expect for issue reported, so users can just copy-and-paste the JSON formatted output such as:

Very nice!

REM self: Also update issue template after docu on wiki.

@mwjames mwjames merged commit 403308c into master Jul 15, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mwjames mwjames deleted the tabs-admin branch Jul 15, 2018
@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jul 23, 2018

Slight visual change from before plus the overview contains now all environment settings we expect for issue reporting, so users can just copy-and-paste the JSON formatted output such as:

@mwjames I think we should have a (section) header here: "Setup information". Starters will not immediately grasp what information is displayed and why.

@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented Jul 23, 2018

kghbln added a commit that referenced this pull request Jul 24, 2018
… (#3254)

* Update SpecialAdmin.php
** Add section header to environment information output
* Update en.json
** Add new system message
* Update qqq.json
** Add new system message documentation
@kghbln kghbln added the enhancement label Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.