Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert log-show-hide-{$type} messages to logeventslist-{$type}-log #3221

Merged
merged 1 commit into from Jul 18, 2018

Conversation

Projects
None yet
3 participants
@prtksxna
Copy link
Contributor

prtksxna commented Jul 16, 2018

This PR is made in reference to: https://phabricator.wikimedia.org/T199657

This PR addresses or contains:

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@kghbln kghbln requested a review from mwjames Jul 16, 2018

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jul 16, 2018

@prtksxna Thanks a lot for the pull!

@mwjames

This comment has been minimized.

Copy link
Contributor

mwjames commented Jul 16, 2018

@prtksxna

This comment has been minimized.

Copy link
Contributor Author

prtksxna commented Jul 16, 2018

Of course, if the new messages are also available for MW 1.27 then
there are no objections.

I don't think these changes will be backported, so yes, in that case we need to keep the old ones. Give me some time to update this PR? I have raised your concern on the main task as well - https://phabricator.wikimedia.org/T199657#4426776

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jul 16, 2018

Give me some time to update this PR?

Yes. :)

Convert log-show-hide-{$type} messages to logeventslist-{$type}-log
Keeping the old message so that the extension continues to work with
older versions of MediaWiki.

Follows-up on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/428871

Bug: https://phabricator.wikimedia.org/T199657

@prtksxna prtksxna force-pushed the prtksxna:log-show-hide branch from 7e3b6ef to d3874ee Jul 18, 2018

@prtksxna

This comment has been minimized.

Copy link
Contributor Author

prtksxna commented Jul 18, 2018

Updated PR to not remove old messages.

@kghbln kghbln merged commit 14cbeba into SemanticMediaWiki:master Jul 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jul 18, 2018

Updated PR to not remove old messages.

Cool, thanks a lot!

@prtksxna prtksxna deleted the prtksxna:log-show-hide branch Jul 18, 2018

kghbln added a commit that referenced this pull request Jul 18, 2018

Convert log-show-hide-{$type} messages to logeventslist-{$type}-log (#…
…3221)

Keeping the old message so that the extension continues to work with
older versions of MediaWiki.

Follows-up on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/428871

Bug: https://phabricator.wikimedia.org/T199657
@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jul 18, 2018

Back-ported to 2.5.x with 954ff20

@kghbln kghbln added this to the SMW 2.5.7 milestone Jul 18, 2018

kghbln added a commit that referenced this pull request Jul 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.