Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special:Browse, Special:PageProperty limit value pool, refs 2930 #3286

Merged
merged 1 commit into from Aug 5, 2018

Conversation

@mwjames
Copy link
Contributor

mwjames commented Aug 5, 2018

This PR is made in reference to: #2930

This PR addresses or contains:

  • Limits the value pool that is displayed for each property in Special:Browse to avoid excessive DB queries. Normally, the display will become user unfriendly on occasions where more than 200 values per property are expected to be displayed therefore the default value for the display is is set to 200 and in case of "more" values, a "..." link is shown and redirects to the Special:PageProperty to lookup all values.
  • smwgPagingLimit contains anew section for the browse outgoing and incoming value list

This PR includes:

  • Tests (unit/integration)
  • CI build passed
@mwjames mwjames added this to the SMW 3.0.0 milestone Aug 5, 2018
@mwjames mwjames merged commit f85cddc into master Aug 5, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mwjames mwjames deleted the limit-value-pool branch Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.