Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rem DeferredRequestDispatchManager, refs 1169 #3310

Merged
merged 1 commit into from Aug 12, 2018

Conversation

@mwjames
Copy link
Contributor

commented Aug 11, 2018

This PR is made in reference to: #1169

This PR addresses or contains:

  • Removes DeferredRequestDispatchManager as not provide any measurable impact
  • Removes the smwgEnabledHttpDeferredJobRequest setting (without deprecation) as it was only meant to direct the behaviour of the DeferredRequestDispatchManager class
  • At the time this class was introduced MW had various issues in regards to the job queue [0] and deferred update. This class tried to mitigate the issues by using a separate socket connection to ensure
    jobs are posted but avoid stalling the update process during a GET request.
  • A follow-up will use a different approach to push FulltextSearchTableUpdateJob and ParserCachePurgeJob as separate request after the update process has been completed

[0] https://phabricator.wikimedia.org/T100085 (and whole lot of relates tasks ...)

This PR includes:

  • Tests (unit/integration)
  • CI build passed
@mwjames mwjames merged commit 6a8d811 into master Aug 12, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mwjames mwjames deleted the rem-def-updater branch Aug 12, 2018
@mwjames mwjames referenced this pull request Aug 12, 2018
1 of 2 tasks complete
@kghbln

This comment has been minimized.

Copy link
Member

commented Sep 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.