Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move FIXED_PROPERTY_ID_UPPERBOUND from 50 to 500, refs 1579 #3314

Merged
merged 1 commit into from Aug 12, 2018

Conversation

@mwjames
Copy link
Contributor

mwjames commented Aug 12, 2018

This PR is made in reference to: #1579, #1014 (comment)

This PR addresses or contains:

  • To allow assigning fixed IDs to properties in upcoming releases
  • This PR moves the FIXED_PROPERTY_ID_UPPERBOUND to 500 with all objects from in that range that are not predefined properties to be moved and assigned a new ID

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Example output

Checking predefined properties ...
   ... allocating space for internal properties ...
   ... moving from 50 to 500 upperbound (may take a moment) ...
       ............................................................
       ............................................................
       ............................................................
       ............................................................
       ............................................................
       ............................................................
       ............................................................
       ..............................
   ... done.
   ... initialize predefined properties ...
   ... done.
@mwjames mwjames added this to the SMW 3.0.0 milestone Aug 12, 2018
@mwjames mwjames force-pushed the move-id-bound branch from d83c1b6 to 0276810 Aug 12, 2018
@mwjames mwjames merged commit 1969bc2 into master Aug 12, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mwjames mwjames deleted the move-id-bound branch Aug 12, 2018
@mwjames mwjames mentioned this pull request Jan 26, 2019
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.