Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DB] Extend ID field length, refs 1184 #3360

Merged
merged 1 commit into from Aug 25, 2018

Conversation

@mwjames
Copy link
Contributor

mwjames commented Aug 25, 2018

This PR is made in reference to: #1184

This PR addresses or contains:

  • Use int(11) instead of int(8) for MySQL/MariaDB (Postgres and SQLite remain unrestricted) which should give enough room to generate IDs for the upcoming 3.x release

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #1184

@mwjames mwjames added this to the SMW 3.0.0 milestone Aug 25, 2018
@mwjames mwjames merged commit 900702d into master Aug 25, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mwjames mwjames deleted the db-id-field branch Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.