New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special:Ask add basic compact view, refs 3180 #3415

Merged
merged 1 commit into from Sep 9, 2018

Conversation

Projects
None yet
3 participants
@mwjames
Copy link
Contributor

mwjames commented Sep 8, 2018

This PR is made in reference to: #3180

This PR addresses or contains:

  • Adds a basic compact view for logged-in users that have enabled the related user preference
  • "Thus I suggest to merge the grey bar and the "ask" form and make it collapsible", collapsible was not considered as a feature given that it would require some effort to rearrange the HTML instead a registered user can choose the enable the basic compact view

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #3180

@mwjames mwjames added the feature label Sep 8, 2018

@mwjames mwjames added this to the SMW 3.0.0 milestone Sep 8, 2018

@JeroenDeDauw

This comment has been minimized.

Copy link
Member

JeroenDeDauw commented Sep 8, 2018

Really cool UI improvement. Does this just affect the page when there are search results, or also before a query gets executed? If only after query execution, then I suspect it makes sense to use the compact view by default.

I am a bit confused by the difference between "compact view" and "basic compact view". What about "default view", "compact view" and "minimal view"? For reference, this is what Gmail has:

image

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Sep 8, 2018

Really cool UI improvement.

+2

Really cool UI improvement. Does this just affect the page when there are search results, or also before a query gets executed? If only after query execution, then I suspect it makes sense to use the compact view by default.

From looking at it I'd say you get either default view before and after or compact view before and basic compact view after. I am not sure though.

What about "default view", "compact view" and "minimal view"?

I am for having this as a default to make sure that anonymous users get the "basic compact view" right way which was the rationale for creating the feature request.

@mwjames mwjames force-pushed the ask-compact-view branch from c7a8a6f to 60be5cf Sep 9, 2018

@mwjames

This comment has been minimized.

Copy link
Contributor

mwjames commented Sep 9, 2018

I am a bit confused by the difference between "compact view" and "basic compact view".
I am for having this as a default to make sure that anonymous users get the "basic compact view" right way which was the rationale for creating the feature request.

After some deliberation, I changed the UI so that the user preference is no longer required yet still gain enough space without the need to distinguish between "compact view" and "basic compact view". This is achieved by relying on tabs to hide auxiliary information.

image

image

@mwjames mwjames merged commit e2f8aff into master Sep 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the ask-compact-view branch Sep 9, 2018

@mwjames mwjames referenced this pull request Sep 9, 2018

Merged

Special:Ask indicate query cache usage #3425

1 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment