New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property page, move usage count display to tab #3440

Merged
merged 1 commit into from Sep 16, 2018

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

mwjames commented Sep 16, 2018

This PR is made in reference to: #

This PR addresses or contains:

  • Moves the count display from the top indicator to an individual tab

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Example

image

@mwjames mwjames merged commit 7e07f03 into master Sep 16, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the prop-usage-count branch Sep 16, 2018

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Sep 17, 2018

@mwjames

This comment has been minimized.

Copy link
Contributor

mwjames commented Sep 17, 2018

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Sep 17, 2018

I've seen this before which relates to predefined properties (and appears in connection with the content language) and is unrelated to the current PR.

Ok. I guess this is on your radar. :)

@mwjames mwjames referenced this pull request Sep 22, 2018

Merged

Property page, predefined property usage count, refs 3440 #3458

1 of 2 tasks complete
@mwjames

This comment has been minimized.

Copy link
Contributor

mwjames commented Sep 22, 2018

Ok. I guess this is on your radar. :)

I believe that to be fixed with #3458.

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Sep 22, 2018

I believe that to be fixed with #3458.

Affirmative. Thanks a lot!

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Sep 22, 2018

@mwjames Another thing I just realize. The information about a property being user defined or deployed by the software went missing. I guess this could still be a useful information in the old spot. Moreover we still have the info on the page being protected in this area, which is good.

@mwjames

This comment has been minimized.

Copy link
Contributor

mwjames commented Sep 22, 2018

Another thing I just realize. The information about a property being user defined or deployed by the software went missing. I guess this could still be a useful information in the old spot.

I thought about it but for predefined properties you always have the intro explaining that it is in fact a predefined property so creating an extra indicator seems somewhat redundant.

Moreover we still have the info on the page being protected in this area, which is good.

The protection is displayed as indicator on the usual place because the state information is separate from the property page.

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Sep 22, 2018

I thought about it but for predefined properties you always have the intro explaining that it is in fact a predefined property so creating an extra indicator seems somewhat redundant.

Fair enough, after a second thought I agree. :)

The protection is displayed as indicator on the usual place because the state information is separate from the property page.

Right. I just mentioned it to convey that the spot would still be useful to put stuff there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment