Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate factbox setting `smwgFactboxFeatures`, refs 2798 #3474

Merged
merged 1 commit into from Sep 23, 2018

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

commented Sep 23, 2018

This PR is made in reference to: #2798

This PR addresses or contains:

  • Adds smwgFactboxFeatures and removes smwgFactboxUseCache, smwgFactboxCacheRefreshOnPurge
  • Default setting for smwgFactboxFeatures is SMW_FACTBOX_CACHE | SMW_FACTBOX_PURGE_REFRESH | SMW_FACTBOX_DISPLAY_SUBOBJECT which is equivalent to the existing setting

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@kghbln kghbln added this to the SMW 3.0.0 milestone Sep 23, 2018

@mwjames mwjames merged commit 38b3769 into master Sep 23, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the tidy-factbox branch Sep 23, 2018

@kghbln

This comment has been minimized.

Copy link
Member

commented Mar 16, 2019

@mwjames

This comment has been minimized.

Copy link
Contributor Author

commented Mar 16, 2019

Documented

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.