New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend `smwgURITypeSchemeList` array #3566

Merged
merged 1 commit into from Jan 6, 2019

Conversation

Projects
None yet
2 participants
@kghbln
Copy link
Member

kghbln commented Jan 5, 2019

This PR is made in reference to: #3533

This PR addresses or contains:

  • Added "sftp" as the secure equivalent to "ftp"
  • Added "git" as a popular URI type
  • Added "ssh" as a popular URI type
  • Added "irc" and "ircs" since a higher proportion of smw users might be nerdy.

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #3533

Extend `smwgURITypeSchemeList` array
- Added "sftp" as the secure equivalent to "ftp"
- Added "git" as a popular URI type
- Added "ssh" as a popular URI type
- Added "irc" and "ircs" since a higher proportion of smw users might be nerdy.

@kghbln kghbln requested a review from mwjames Jan 5, 2019

@mwjames mwjames merged commit 084db00 into master Jan 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the issue-3533 branch Jan 6, 2019

@kghbln

This comment has been minimized.

Copy link
Member Author

kghbln commented Jan 6, 2019

kghbln added a commit that referenced this pull request Jan 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment