New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect pipe `[[ ... | ... ]]` in printrequest label, refs 3523, 3211 #3584

Merged
merged 1 commit into from Jan 6, 2019

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

mwjames commented Jan 6, 2019

This PR is made in reference to: #3523, #3211, 6d351bb

This PR addresses or contains:

  • Encodes | in [[ ... | ... ]] before splitting the value parameter

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #3523

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jan 6, 2019

I guess I may back-port this one, too?

@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented Jan 6, 2019

I guess I may back-port this one, too?

In case you backport (since I avoided diluting the issue with a tidy), 6d351bb is required before this PR.

@mwjames mwjames merged commit fec37d7 into master Jan 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the issue-3523 branch Jan 6, 2019

kghbln added a commit that referenced this pull request Jan 11, 2019

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jan 11, 2019

In case you backport (since I avoided diluting the issue with a tidy), 6d351bb is required before this PR.

Thanks for the note! Back-ported with 846b9f3 and 1205b87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment