New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "strpos(): Non-string needles ...", refs 3579, 3556 #3585

Merged
merged 1 commit into from Jan 6, 2019

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

mwjames commented Jan 6, 2019

This PR is made in reference to: #3579, #3556

This PR addresses or contains:

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #3579

@mwjames mwjames merged commit f5a1a8e into master Jan 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the php-7.3 branch Jan 6, 2019

@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented Jan 6, 2019

@kghbln @JeroenDeDauw PR has been merged, so you may try adding PHP 7.3 again.

image

This was referenced Jan 11, 2019

@kghbln kghbln added this to the SMW 3.0.1 milestone Jan 19, 2019

kghbln added a commit that referenced this pull request Jan 19, 2019

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jan 19, 2019

Back-ported with 5d6d6ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment