New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject RecurringEvents, refs 3541 #3586

Merged
merged 1 commit into from Jan 12, 2019

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

mwjames commented Jan 6, 2019

This PR is made in reference to: #3541

This PR addresses or contains:

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #3541

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jan 11, 2019

Thanks a lot for the pull. This was one of the biggest issues in 2.5 and 3.0 I believe.

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jan 11, 2019

@mwjames Since we were not testing #set_recurring_event at all I figured it will be a good idea to add some more testing #3592 and #3593

@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented Jan 12, 2019

@mwjames Since we were not testing #set_recurring_event at all I figured it will be a good idea to add some more testing #3592 and #3593

That's the spirit I'd like to see from others (@kghbln @hexmode @krabina @planetenxin @s7eph4n @jamesmontalvo3) to get involved and evolve the software, not necessarily by extending its functionality but by providing test scenarios to keep existing (or assumed) functions tested and provide means for upcoming changes to be less likely in a center for a regression.

@mwjames mwjames merged commit 35d9a24 into master Jan 12, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the issue-3541 branch Jan 12, 2019

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jan 12, 2019

That's the spirit I'd like to from others

Thanks for the cheer-up. However I must admit that adding these tests still proved to be insufficient to catch all issues, i.e. expanding test is an ongoing process.

kghbln added a commit that referenced this pull request Jan 18, 2019

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jan 18, 2019

Back-ported with 53655ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment