New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlink invalid user names, refs 3278 #3595

Merged
merged 1 commit into from Jan 12, 2019

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

mwjames commented Jan 12, 2019

This PR is made in reference to: #3278

This PR addresses or contains:

  • I found myself clicking on users that don't exist such as User:Test>Importer, fixing related ticked for the SMW specific interfaces.

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes: #3278

@mwjames mwjames merged commit fde8a95 into master Jan 12, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the issue-3278 branch Jan 12, 2019

@kghbln kghbln added this to the SMW 3.0.1 milestone Jan 12, 2019

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jan 12, 2019

@mwjames I think this can be back-ported?

Anyways I am not sure what the difference is in comparison to the situation before. To me the result on sandbox looks alike.

@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented Jan 12, 2019

Anyways I am not sure what the difference is in comparison to the situation before. To me the result on sandbox looks alike.

The sandbox has an old (9c19d87, see Special:Version) version. Composer hasn't updated [0] the sha1 ref (see the bottom which says 9c19d87...) hence the sandbox is outdated and doesn't have the submitted changes (same with the recurring events).

[0] https://packagist.org/packages/mediawiki/semantic-media-wiki#dev-master

@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented Jan 12, 2019

The sandbox has an old (9c19d87, see Special:Version) version. Composer hasn't updated [0] the sha1 ref (see the bottom which says 9c19d87...) hence

No updates could be related to Github's webhook changes "Note: GitHub Services are being deprecated. Please contact your integrator for more information on how to migrate or replace a service with webhooks or GitHub Apps" [1, 2], I tried to add it but have insufficient rights [0, 3]. Maybe @JeroenDeDauw could give it a go?

[0] https://github.com/SemanticMediaWiki/SemanticMediaWiki/settings/hooks
[1] https://github.com/SemanticMediaWiki/SemanticMediaWiki/settings/installations
[2] https://developer.github.com/changes/2018-04-25-github-services-deprecation/
[3] https://packagist.org/about

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jan 12, 2019

Ok, it worked now. I am on master. I thought that five hours after the commit would be sufficient to infiltrate the changes to end users. However the changes by GitHub may be a source for it to take so long.

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jan 12, 2019

Affirmative. I now see the effect of this commit. Thanks a lot!

Ready to back-port?

@kghbln kghbln removed this from the SMW 3.0.1 milestone Jan 18, 2019

kghbln added a commit that referenced this pull request Jan 18, 2019

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jan 18, 2019

Back-ported with e9ed65e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment