New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Call to undefined method SMWDIError::getJD()" #3607

Merged
merged 2 commits into from Jan 13, 2019

Conversation

Projects
None yet
2 participants
@kghbln
Copy link
Member

kghbln commented Jan 12, 2019

This PR is made in reference to: #3598

This PR addresses or contains:

  • Fixes #set_recurring_event: causing "Call to undefined method SMWDIError::getJD()" as suggested by @mwjames in #3598 (comment)

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #3598

@mwjames

This comment has been minimized.

Copy link
Contributor

mwjames commented on includes/RecurringEvents.php in c234c57 Jan 12, 2019

You somehow added more than there was before!

@@ -305,6 +307,10 @@ public function parse( array $parameters ) {
$new_month = 12;
}
if ( $cur_date->isValid() ) {

This comment has been minimized.

@mwjames

mwjames Jan 12, 2019

Contributor

Remove line 310-313 which were added by the PR!

@kghbln

This comment has been minimized.

Copy link
Member Author

kghbln commented Jan 12, 2019

You somehow added more than there was before!

Nope, this is an exact copy of what I did before. However these lines can be deleted.

@mwjames

This comment has been minimized.

Copy link
Contributor

mwjames commented Jan 12, 2019

Nope, this is an exact copy of what I did before. However these lines can be deleted.

You added those lines which weren't there before only line $cur_date_jd = $cur_date->getDataItem()->getJD(); was the issue.

@mwjames mwjames merged commit af7577e into master Jan 13, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the issue-3598-1 branch Jan 13, 2019

@kghbln

This comment has been minimized.

Copy link
Member Author

kghbln commented Jan 18, 2019

Back-ported with 4d9e5a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment