New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryResultSerializer to handle `_qty` on chained property, refs 3517 #3608

Merged
merged 1 commit into from Jan 13, 2019

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

mwjames commented Jan 12, 2019

This PR is made in reference to: #3517

This PR addresses or contains:

  • Fixes the "TypeError: Argument 2 passed to SMW\DataValueFactory::newDataValueByItem() must be an instance of SMW\DIProperty or null, instance of SMWDIBlob given, called in ...\SemanticMediaWiki\src\Serializers\QueryResultSerializer.php on line 133" caused by the property chain
  • Adds integration test with the example from #3517 that uncovered the error
  • However it does not resolve the DataTables format (initially reported) on how it should interpret the values from the API and display them which is an entire different matter in SRF

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #3517

@mwjames mwjames merged commit e7767bf into master Jan 13, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the issue-3517 branch Jan 13, 2019

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jan 18, 2019

Back-ported with b17526d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment