New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set `isCapitalLinks` in `_wpg` description context, refs 3587 #3616

Merged
merged 1 commit into from Jan 13, 2019

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

mwjames commented Jan 13, 2019

This PR is made in reference to: #3587

This PR addresses or contains:

  • Set the isCapitalLinks context for a _wpg type when it matches SMW_CMP_EQ or SMW_CMP_NEQ and wgCapitalLinks is true to result in:
    • {{#show: foo ...}} === {{#show: Foo}}
    • {{#ask: [[foo]] ...}} === {{#ask: [[Foo]] ...}}
  • isCapitalLinks only affects the first letter (same rules applies for Title::newFromText)

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #3587

@mwjames mwjames merged commit 19b3f19 into master Jan 13, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the issue-3587 branch Jan 13, 2019

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jan 18, 2019

Back-ported with 4b0cfb7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment