New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows recurring events to start on a 30th or 31st of a month #3622

Merged
merged 3 commits into from Jan 17, 2019

Conversation

Projects
None yet
1 participant
@kghbln
Copy link
Member

kghbln commented Jan 17, 2019

This PR is made in reference to: #3619

This PR addresses or contains:

  • Fixes recurring events not being created for every month if they start on a 30th or 31st
  • Provides integration tests for recurring events starting on 29th (including a check for leap years), 30th and 31st. This assumes that recurring events are being created for the last day of the month if the respective month does not have a 29th, 30th or 31st day (per #3619 (comment))

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #3619

kghbln added some commits Jan 15, 2019

Provide test for end of month recurring events
This commit is to provide the integration test for the issue reported with #3619 and fails since currently not fix is available.

- Testing the 29th - passing
- Testing the 30th - failing
- Testing the 31st - failing

[skip ci]
Update p-0115.json
Fix integration test

[skip ci]

@kghbln kghbln changed the title Also allow recurring events starting on a 30th or 31st of a month Allow recurring events starting on a 30th or 31st of a month Jan 17, 2019

@kghbln

This comment has been minimized.

Copy link
Member Author

kghbln commented Jan 17, 2019

Looks like this will soon be ready for a squash and merge. :)

@kghbln kghbln changed the title Allow recurring events starting on a 30th or 31st of a month Allows recurring events to start on a 30th or 31st of a month Jan 17, 2019

@kghbln kghbln merged commit 5622a31 into master Jan 17, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@kghbln kghbln deleted the issue-3619 branch Jan 17, 2019

kghbln added a commit that referenced this pull request Jan 18, 2019

Allows recurring events to start on a 30th or 31st of a month (#3622)
* Allows recurring events to start on a 30th or 31st of a month

Code change as suggested by @mwjames #3619 (comment)

* Provides test for end of month recurring events
@kghbln

This comment has been minimized.

Copy link
Member Author

kghbln commented Jan 18, 2019

Back-ported with cfbd338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment