Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `IsFileCacheable` hook #3682

merged 1 commit into from Feb 2, 2019


None yet
3 participants
Copy link

commented Feb 2, 2019

This PR is made in reference to: #2847,

This PR addresses or contains:

  • Introduced as part of #2847 to "Disallow the file cache to avoid skipping the ArticleViewHeader hook on Article::tryFileCache" in connection with $smwgEnabledQueryDependencyLinksStore but since we switched on using RejectParserCacheValue and no longer have to rely on the ArticleViewHeader hook to evict the parser cache we can remove the IsFileCacheable hook usage.
  • IsFileCacheable hook allows an extension to disable file caching on pages

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@kghbln kghbln added the enhancement label Feb 2, 2019

@kghbln kghbln added this to the SMW 3.1.0 milestone Feb 2, 2019

@mwjames mwjames merged commit a35f132 into master Feb 2, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@mwjames mwjames deleted the hook branch Feb 2, 2019


This comment has been minimized.

Copy link

commented Feb 2, 2019

Beautiful! Thanks!

mwjames added a commit that referenced this pull request Mar 17, 2019

@kghbln kghbln modified the milestones: SMW 3.1.0, SMW 3.0.2 Mar 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.