Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support `in.maintenance_mode`, refs 3596, 3715 #3738

Merged
merged 1 commit into from Feb 24, 2019
Merged

Support `in.maintenance_mode`, refs 3596, 3715 #3738

merged 1 commit into from Feb 24, 2019

Conversation

@mwjames
Copy link
Contributor

mwjames commented Feb 24, 2019

This PR is made in reference to: #3596, #3715

This PR addresses or contains:

  • Adds in.maintenance_mode to provide a better feedback to users when the upgrade is ongoing meaning when the setup/update script runs hereby communicates that things are going to take a moment instead of just displaying the error message

This PR includes:

  • Tests (unit/integration)
  • CI build passed

No maintenance activities

image

Setup/update in-progress

image

@mwjames mwjames added this to the SMW 3.1.0 milestone Feb 24, 2019
@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented Feb 24, 2019

@kghbln I just switched a test wiki (2.5 to 3.x) with 4 mil rows (in the smw_object_ids table) and due to the smw_id/s_id conversion to (int 11, #3360) it took about an hour (well the hardware wasn't much up-to-date) anyway, instead of continuing to show for an hour the error message it now shows the the second screen when the actual update is in progress.

@mwjames mwjames merged commit 68f31ca into master Feb 24, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mwjames mwjames deleted the is-maintenance branch Feb 24, 2019
@mwjames mwjames added the feature label Mar 3, 2019
@mwjames mwjames mentioned this pull request May 18, 2019
1 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.