Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema group import, refs 2874 #3749

Merged
merged 1 commit into from Mar 3, 2019
Merged

Add schema group import, refs 2874 #3749

merged 1 commit into from Mar 3, 2019

Conversation

@mwjames
Copy link
Contributor

mwjames commented Mar 3, 2019

This PR is made in reference to: #2874

This PR addresses or contains:

  • Adds PROPERTY_GROUP_SCHEMA for isolating the management of group assignments via a schema
  • import/smw.groups.json/schema.json define the import for creating a group for schema related properties

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #

@mwjames mwjames added the enhancement label Mar 3, 2019
@mwjames mwjames added this to the SMW 3.1.0 milestone Mar 3, 2019
@mwjames mwjames merged commit 219f0cf into master Mar 3, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mwjames mwjames deleted the schema-group branch Mar 3, 2019
@mwjames

This comment has been minimized.

@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented Mar 3, 2019

As with the schema.json import example (contains group definition for _SCHEMA* related properties), the intent is to have a deployment mechanism where properties can be grouped (SESP properties etc.) without a user having to manually create categories and annotated them with Is property group.

A Is property group definition to a category (and hereby property) takes precedence over any group definition found in PROPERTY_GROUP_SCHEMA, so a property listed as part of a PROPERTY_GROUP_SCHEMA where a listed property itself is assigned to category and that category Is property group, the property will be a member of the category assigned group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.