Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `doPostOutputShutdown`, refs 3690 #3771

Merged
merged 1 commit into from Mar 9, 2019

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

commented Mar 9, 2019

This PR is made in reference to: #3690

This PR addresses or contains:

  • According to #3690, if remove doPostOutputShutdown then there should be no issue with MW 1.33

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #3690

@mwjames mwjames merged commit 5748437 into master Mar 9, 2019

@mwjames mwjames deleted the issue-3690 branch Mar 9, 2019

mwjames added a commit that referenced this pull request Mar 9, 2019

@mwjames

This comment has been minimized.

Copy link
Contributor Author

commented Mar 16, 2019

@kghbln Can be considered for 3.0.2.

@kghbln kghbln added the code quality label Mar 16, 2019

@kghbln kghbln added this to the SMW 3.0.2 milestone Mar 16, 2019

kghbln added a commit that referenced this pull request Mar 16, 2019

@kghbln

This comment has been minimized.

Copy link
Member

commented Mar 16, 2019

Thanks for the info. Back-ported with b7a78e0

@kghbln kghbln removed the code quality label Mar 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.