Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "... expects parameter 1 to be a valid callback ...", refs 3765 #3772

Merged
merged 1 commit into from Mar 9, 2019

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

commented Mar 9, 2019

This PR is made in reference to: #3765

This PR addresses or contains:

  • cancelOnRollback was setting a null and caused "PHP Warning: call_user_func() expects parameter 1 to be a valid callback, no array or string given"

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #3765

@mwjames mwjames merged commit ff2b904 into master Mar 9, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the issue-3765 branch Mar 9, 2019

@kghbln

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

@mwjames Thanks a lot for the fix. I added the preliminary fix to the respective wiki just to get this on another wiki. :| May this be back-ported to 3.0.x?

@kghbln kghbln added this to the SMW 3.0.2 milestone Mar 13, 2019

@mwjames

This comment has been minimized.

Copy link
Contributor Author

commented Mar 16, 2019

May this be back-ported to 3.0.x?

Yes.

@kghbln

This comment has been minimized.

Copy link
Member

commented Mar 16, 2019

Thanks for the info. Back-ported with 79e4adb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.