Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide new test case for display title #3854

Merged
merged 2 commits into from Mar 28, 2019

Conversation

Projects
None yet
2 participants
@kghbln
Copy link
Member

commented Mar 27, 2019

This PR is made in reference to: #3853

This PR addresses or contains:

  • Provide new test case for #ask on format=template, link=none and DISPLAYTITLE with nested template // suggested by @mwjames at #3853 (comment)

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #3853

@mwjames

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@kghbln

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

The test output (spaces) is a bit different due to some copy-and-paste issue. I hope the diff helps.

This was not just copy paste. I redid the whole thing and manually converted it to prettyprint. GitHub totally scrambles this since it is wider than the box. The new diff does make it better. So there is e.g. really a hard break between the a and href?

Update p-0712.json
Fix test

@kghbln kghbln merged commit fabbdcd into master Mar 28, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@kghbln kghbln deleted the issue-3853 branch Mar 28, 2019

kghbln added a commit that referenced this pull request Mar 28, 2019

Provide new test case for display title (#3854)
* Provide new test case for display title
@kghbln

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2019

Back-ported with d05671e

@kghbln kghbln added this to the SMW 3.0.2 milestone Mar 28, 2019

@kghbln kghbln added the code quality label Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.