Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch setting of `smwgCompactLinkSupport` to "false" #3856

Merged
merged 1 commit into from Mar 28, 2019

Conversation

Projects
None yet
2 participants
@kghbln
Copy link
Member

commented Mar 27, 2019

This PR is made in reference to: #3855

This PR addresses or contains:

  • Switch setting of smwgCompactLinkSupport to "false" in the light of the findings described in the issue report referenced

I must note that this is a sad but necessary change.

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #3855

@kghbln

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

Since this is a backwards compatible change this may be back-ported to 3.0.x

@kghbln kghbln added this to the SMW 3.0.2 milestone Mar 27, 2019

@kghbln kghbln merged commit a1c02fd into master Mar 28, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@kghbln kghbln deleted the issue-3855 branch Mar 28, 2019

kghbln added a commit that referenced this pull request Mar 28, 2019

@kghbln

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2019

Back-ported with 767c981

@kghbln

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2019

Back-ported with 767c981

@mwjames Now the build fails, but as far as I see due to unrelated issues. :(

@mwjames

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

This was referenced Mar 28, 2019

@kghbln

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2019

Thanks a lot. Just created a pull. What makes me grumpy is that I branch from 3.0.x and GitHub wants to merge to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.