Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace `localpath` with `localBasePath`, refs 3861 #3863

Merged
merged 1 commit into from Mar 30, 2019

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

commented Mar 30, 2019

This PR is made in reference to: #3861

This PR addresses or contains:

  • Regression caused by 1fad17a#r32968076

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #3861

@mwjames mwjames merged commit 6aa5210 into master Mar 30, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the issue-3861 branch Mar 30, 2019

@mwjames

This comment has been minimized.

Copy link
Contributor Author

commented Mar 30, 2019

@kghbln PR should be unproblematic for 3.0.2.

@kghbln kghbln added this to the SMW 3.0.2 milestone Apr 2, 2019

@kghbln kghbln added the releasenotes label Apr 2, 2019

@kghbln

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

@kghbln PR should be unproblematic for 3.0.2.

I am afraid it is. The cherry picking fails to edit conflicts and after I resolved them and would like to back-port Git tells me that branch 3.0.x is up to day. Done this twice now and decided to withdraw from it. So this will be 3.1.0.

@kghbln kghbln removed the releasenotes label Apr 2, 2019

@kghbln kghbln modified the milestones: SMW 3.0.2, SMW 3.1.0 Apr 2, 2019

kghbln added a commit that referenced this pull request Apr 10, 2019

@kghbln

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Ok, I figured out what I did wrong. It is just that I do this pretty infrequent.

@kghbln kghbln modified the milestones: SMW 3.1.0, SMW 3.0.2 Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.