MW 1.23+ / Hotfix for empty ParserOutput caused by RefreshLinksJob #405

Merged
merged 1 commit into from Jul 19, 2014

Conversation

Projects
None yet
3 participants
Contributor

mwjames commented Jul 14, 2014

For details on the issue, see [0] as well as the method to replicate the problem.

[0] #347 (comment)

mwjames added this to the SMW 2.0 milestone Jul 14, 2014

mwjames changed the title from Hotfix for empty ParserOutput caused by RefreshLinksJob (MW 1.23+) to MW 1.23+ / Hotfix for empty ParserOutput caused by RefreshLinksJob Jul 17, 2014

@mwjames mwjames MW 1.23+ / Hotfix for empty ParserOutput caused by RefreshLinksJob
For details on the issue, see [0] as well as the method to replicate
the problem.
464955e

The inspection completed: 2 new issues, 3 updated code elements

@JeroenDeDauw JeroenDeDauw commented on the diff Jul 19, 2014

...on/MediaWiki/LinksUpdateSQLStoreDBIntegrationTest.php
@@ -231,7 +231,7 @@ public function propertyCountProvider() {
'msg' => 'Asserts property Aa, Fuyu, _SKEY, and _MDAT from the previous state as no update has been made yet'
),
'poAfter' => array(
- 'count' => 1,
+ 'count' => 0,
@JeroenDeDauw

JeroenDeDauw Jul 19, 2014

Owner

Why did this change?

@mwjames

mwjames Jul 19, 2014

Contributor

In the process where isEmpty is caught (as in the above case) the new parse would not run through NewRevisionFromEditComplete (which is responsible to add _MDAT early on) therefore is missing the pre-defined property but successively added by by the StoreUpdater which still counts for the final 4 properties ( 2 user-defined + '_MDAT' and '_SKEY).

@JeroenDeDauw

JeroenDeDauw Jul 19, 2014

Owner

Ok, sure. This data provider is rather cryptic

JeroenDeDauw merged commit fa96681 into master Jul 19, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

JeroenDeDauw deleted the hotfix-linksupdate branch Jul 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment