Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Setup::MINIMUM_DB_VERSION, refs 4439, 4438 #4461

Merged
merged 1 commit into from Jan 25, 2020
Merged

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Jan 25, 2020

This PR is made in reference to: #4439, #4438

This PR addresses or contains:

  • Setup::MINIMUM_DB_VERSION contains the min requirement definition
  • SetupCheck/Installer will examine the MINIMUM_DB_VERSION (is required for a different PR that needs to raise the minimum for postgres/sqlite)
  • Setup::MINIMUM_DB_VERSION has been added to the upgrade key (see SetupFile::makeKey) which means anytime the definition is altered, a new upgrade key will be necessary and ensures that update.php/setupStore.php is run first to check and inform users in case the requirement isn't met hereby blocks SMW (as below)

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Example

Command line

$ php maintenance/setupStore.php

Semantic MediaWiki:                                             3.2.0-alpha
MediaWiki:                                                           1.33.1

--- Database setup --------------------------------------------------------

Storage engine:                                                SMWSQLStore3

--- Compatibility notice --------------------------------------------------

The postgres database version of 9.6.16 doesn't meet the minimum
requirement of 19.2 for Semantic MediaWiki.

The installation of Semantic MediaWiki was aborted!

Web

image

@mwjames mwjames added the enhancement Alters an existing functionality or behaviour label Jan 25, 2020
@kghbln kghbln added this to the SMW 3.2.0 milestone Jan 25, 2020
@mwjames mwjames merged commit 25e96b3 into master Jan 25, 2020
@mwjames mwjames deleted the check-db-version branch Jan 25, 2020
mwjames added a commit that referenced this pull request Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Alters an existing functionality or behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants