Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check last_optimization_run, add maintenance alert #4476

Merged
merged 1 commit into from Jan 26, 2020

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Jan 26, 2020

This PR is made in reference to: #4468

This PR addresses or contains:

  • Records the last_optimization_run in the setup file (.smw.json) and when overdue will create an alter via LastOptimizationRunMaintenanceAlertTaskHandler
  • Adds SMW_ADM_ALERT_LAST_OPTIMIZATION_RUN as option (enabled by default) to smwgAdminFeatures

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Example

image

@mwjames mwjames added the feature A new, or altered behaviour of an existing functionality that fundamentally impacts behaviour label Jan 26, 2020
@mwjames mwjames force-pushed the admin-alerts-table-optimization branch from 5c94a77 to 292c6b4 Compare Jan 26, 2020
@mwjames mwjames changed the title Check last_optimize_run, add maintenance alert Check last_optimization_run, add maintenance alert Jan 26, 2020
@mwjames mwjames merged commit 355b649 into master Jan 26, 2020
@mwjames mwjames deleted the admin-alerts-table-optimization branch Jan 26, 2020
@kghbln kghbln added the wikidocu missing Code changes (mostly features) what have not yet been documented label Apr 25, 2020
@kghbln
Copy link
Member

kghbln commented Apr 25, 2020

@mwjames What time span is considered to trigger the alters for the task being overdue?

@kghbln
Copy link
Member

kghbln commented Apr 25, 2020

Documented

@kghbln kghbln removed the wikidocu missing Code changes (mostly features) what have not yet been documented label Apr 25, 2020
@mwjames
Copy link
Contributor Author

mwjames commented Apr 25, 2020

@mwjames What time span is considered to trigger the alters for the task being overdue?

I didn't bother to add any customizing for this, it is currently fixed to 90 days and defined in [0].

[0]

/**
* Defines the threshold in days, exceeding the threholds will trigger the
* alert.
*/
const DAYS_THRESHOLD = 90; // 3 Month;

@kghbln
Copy link
Member

kghbln commented Apr 25, 2020

I didn't bother to add any customizing for this, it is currently fixed to 90 days and defined in [0].

Must have overlooked this when looking at the diff. No worries. Good enough for me.

@kghbln
Copy link
Member

kghbln commented Apr 25, 2020

Noted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new, or altered behaviour of an existing functionality that fundamentally impacts behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants