New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SMW_CONCEPT_QUERY to enable concept in concepts (Bug 44467) #546

Merged
merged 1 commit into from Oct 2, 2014

Conversation

Projects
None yet
4 participants
@mwjames
Contributor

mwjames commented Sep 21, 2014

Integration test

  • Create Concept:ContainsAllPopulationProperty with {{#concept: [[Population::+]] }}
  • Create Concept:ContainsOnlySpecificAreaValue with {{#concept: [[Area::SomeDistinctValue]] }}
  • Create Concept:CombinedConceptQuery with {{#concept: [[Concept::ContainsAllPopulationProperty]][[Concept::ContainsOnlySpecificAreaValue]] }}

@mwjames mwjames added the enhancement label Sep 21, 2014

@mwjames mwjames added this to the SMW 2.1 milestone Sep 21, 2014

@mwjames

This comment has been minimized.

Show comment
Hide comment
@mwjames

mwjames Sep 21, 2014

Contributor

@kghbln As the originator of the Bug 44467, it would be great if you could test this to some extend.

Contributor

mwjames commented Sep 21, 2014

@kghbln As the originator of the Bug 44467, it would be great if you could test this to some extend.

@kghbln

This comment has been minimized.

Show comment
Hide comment
@kghbln

kghbln Sep 28, 2014

Member

I finally was able to successfully test with pull request. It is really great to have this. Thanks a ton for doing this!!! Kudos!!! I also noticed that SMW now tells the date the concept was updated/created last time which is cool, too.

Member

kghbln commented Sep 28, 2014

I finally was able to successfully test with pull request. It is really great to have this. Thanks a ton for doing this!!! Kudos!!! I also noticed that SMW now tells the date the concept was updated/created last time which is cool, too.

@mwjames

This comment has been minimized.

Show comment
Hide comment
@mwjames

mwjames Sep 28, 2014

Contributor

I also noticed that SMW now tells the date the concept was updated/created last time which is cool, too.

Well, this feature was introduced with 6dd845e.

Contributor

mwjames commented Sep 28, 2014

I also noticed that SMW now tells the date the concept was updated/created last time which is cool, too.

Well, this feature was introduced with 6dd845e.

@kghbln

This comment has been minimized.

Show comment
Hide comment
@kghbln

kghbln Sep 28, 2014

Member

Ah, a 1.9+ feature. Could have figured this out myself. I am still on 1.8.x, except for the little test wiki :| Great thing anyway!

Member

kghbln commented Sep 28, 2014

Ah, a 1.9+ feature. Could have figured this out myself. I am still on 1.8.x, except for the little test wiki :| Great thing anyway!

mwjames added a commit that referenced this pull request Oct 2, 2014

Merge pull request #546 from SemanticMediaWiki/nested-concept-query
Add SMW_CONCEPT_QUERY to enable concept in concepts (Bug 44467)

@mwjames mwjames merged commit 09d92bb into master Oct 2, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@mwjames mwjames deleted the nested-concept-query branch Oct 2, 2014

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 2, 2014

The inspection completed: 126 new issues, 6 updated code elements

scrutinizer-notifier commented Oct 2, 2014

The inspection completed: 126 new issues, 6 updated code elements

@JeroenDeDauw

This comment has been minimized.

Show comment
Hide comment
@JeroenDeDauw

JeroenDeDauw Oct 2, 2014

Member

Ah, a 1.9+ feature. Could have figured this out myself. I am still on 1.8.x, except for the little test wiki :| Great thing anyway!

What?! You need to upgrade ASAP, or I'll have no choice but to revoke

fluffy

Member

JeroenDeDauw commented Oct 2, 2014

Ah, a 1.9+ feature. Could have figured this out myself. I am still on 1.8.x, except for the little test wiki :| Great thing anyway!

What?! You need to upgrade ASAP, or I'll have no choice but to revoke

fluffy

@kghbln

This comment has been minimized.

Show comment
Hide comment
@kghbln
Member

kghbln commented Nov 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment