New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `--runtime` to `rebuildConceptCache` #829

Merged
merged 1 commit into from Feb 15, 2015

Conversation

Projects
None yet
3 participants
@mwjames
Contributor

mwjames commented Feb 15, 2015

No description provided.

mwjames added a commit that referenced this pull request Feb 15, 2015

@mwjames mwjames merged commit d05abb5 into master Feb 15, 2015

1 of 2 checks passed

Scrutinizer Running Analyses
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@mwjames mwjames deleted the rebuildconc-runtime branch Feb 15, 2015

@@ -100,6 +99,7 @@ protected function addDefaultParams() {
$this->addOption( 's', '<startid> Process only concepts with page id of at least <startid>', false, true );
$this->addOption( 'e', '<endid> Process only concepts with page id of at most <endid>', false, true );
$this->addOption( 'runtime', 'Will display the runtime environment of the script', false );

This comment has been minimized.

@JeroenDeDauw

JeroenDeDauw Feb 15, 2015

Member

runtime environment

This makes me think it's about the PHP version or something like that. Improved in #830

@JeroenDeDauw

JeroenDeDauw Feb 15, 2015

Member

runtime environment

This makes me think it's about the PHP version or something like that. Improved in #830

This comment has been minimized.

@JeroenDeDauw

JeroenDeDauw Feb 15, 2015

Member

The option name itself is still ambiguous though. http://en.wikipedia.org/wiki/Run_time

--display-runtime is probably better, and this also makes it clear it's an option, and not something expecting a value

Then again, it is not just about the execution time. --display-resource-consumption is more accurate, though kinda long

@JeroenDeDauw

JeroenDeDauw Feb 15, 2015

Member

The option name itself is still ambiguous though. http://en.wikipedia.org/wiki/Run_time

--display-runtime is probably better, and this also makes it clear it's an option, and not something expecting a value

Then again, it is not just about the execution time. --display-resource-consumption is more accurate, though kinda long

@kghbln

This comment has been minimized.

Show comment
Hide comment
@kghbln

kghbln Mar 24, 2015

Member

This is now documented on wiki.

Member

kghbln commented Mar 24, 2015

This is now documented on wiki.

@kghbln kghbln added this to the SMW 2.2 milestone Mar 26, 2015

kghbln added a commit that referenced this pull request Mar 26, 2015

Update RELEASE-NOTES.md
Add information about pull request #829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment