Fix coding style issues #899 in tests/

[jongfeli]

I summarized the ones that are left in tests/. I am more then happy to fix those that can be fixed or improved but not without help. I would appreciate if someone could mark the ones that can be fixed or improved and if so explain how to do this, when possible.

And for the ones that can not be fixed but should be sniffed should we use @codingStandardsIgnoreStart and @codingStandardsIgnoreEnd tags like suggested in #899 but how? I had look in [ConjunctionConditionBuilder.php] but I am not sure if this is correct:

Now:

            if ( $subCondition instanceof FalseCondition ) {
                return new FalseCondition();
            } elseif ( $subCondition instanceof TrueCondition ) {
                // ignore true conditions in a conjunction
            } elseif ( $subCondition instanceof WhereCondition ) {
                $subConditionElements->condition .= $subCondition->condition;
            } elseif ( $subCondition instanceof FilterCondition ) {

Becomes:

            if ( $subCondition instanceof FalseCondition ) {
                return new FalseCondition();
            } // @codingStandardsIgnoreStart
            elseif ( $subCondition instanceof TrueCondition ) {
                // ignore true conditions in a conjunction
            } // @codingStandardsIgnoreEnd
            elseif ( $subCondition instanceof WhereCondition ) {
                $subConditionElements->condition .= $subCondition->condition;
            } elseif ( $subCondition instanceof FilterCondition ) {

[JeroenDeDauw]

The example change you posted looks good to me

[JeroenDeDauw]

I summarized the ones that are left in tests/. I am more then happy to fix those that can be fixed or improved but not without help. I would appreciate if someone could mark the ones that can be fixed or improved and if so explain how to do this, when possible.

Cool! I'll have a look and leave inline comments here jongfeli/Code-violations-SemanticMediaWiki@f358e97

[JeroenDeDauw]

Protip: make your commits on a branch (that is not master) and then push the branch to your GitHub remote

[JeroenDeDauw]

I've submitted your commits plus a merge conflict fix from me in a new PR: #931