Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTables format: Image links a being replaced in the wrong column #188

Open
octfx opened this issue Dec 17, 2016 · 12 comments
Labels
bug

Comments

@octfx
Copy link

@octfx octfx commented Dec 17, 2016

Setup

  • MW version: 1.28.0
  • DB (MySQL etc.): MariaDB 10
  • PHP version: 7
  • SMW version: 2.4.3
  • SRF version: master (17.10.2016)

Issue

The column next to the image links is replaced by DataTables and not the image links itself.
Example: https://star-citizen.wiki/Benutzer:FoXFTW/Spielwiese
Images should appear in the "Kopfbild" column, but the "Hersteller" column is replaced instead.

@kghbln kghbln added the bug label Dec 20, 2016
@kghbln

This comment has been minimized.

Copy link
Member

@kghbln kghbln commented Dec 20, 2016

Thanks for reporting! That indeed does not appear to be an expected behaviour.

@kghbln kghbln changed the title Image links replacing the wrong column in DataTables DataTables format / Image links a being replaced in the wrong column Dec 20, 2016
@kghbln

This comment has been minimized.

Copy link
Member

@kghbln kghbln commented Feb 20, 2018

Reported again as #372

Still present with:

  • MediaWiki | 1.27.4 (317104c)23:34, 7 February 2018
  • PHP | 7.0.25-0ubuntu0.16.04.1 (apache2handler)
  • MySQL | 5.7.21-0ubuntu0.16.04.1
  • Semantic MediaWiki | 2.5.7-alpha (e0c6791) 15:00, 14 February 2018
  • Semantic Result Formats | 2.5.5-alpha (aad259d) 15:31, 11 December 2017

Example at www.semantic-mediawiki.org

@kghbln kghbln changed the title DataTables format / Image links a being replaced in the wrong column DataTables format: Image links a being replaced in the wrong column Feb 20, 2018
@krabina

This comment has been minimized.

Copy link
Contributor

@krabina krabina commented Dec 16, 2018

It is still present in SRF 3.0
https://www.semantic-mediawiki.org/wiki/Demo:Datatables_compared_to_broadtable

MediaWiki | 1.31.1 (141cb48)22:39, 5 December 2018
PHP | 7.0.32-0ubuntu0.16.04.1 (apache2handler)
MySQL | 5.7.24-0ubuntu0.16.04.1
Lua | 5.1.5

Semantic MediaWiki | 3.0.0 (abdec88) 22:29, 11 October 2018
Semantic Result Formats | 3.0.0 (36ced8d) 09:15, 12 October 2018

@kghbln

This comment has been minimized.

Copy link
Member

@kghbln kghbln commented Dec 16, 2018

@krabina Are you sure? The example page you provided only shows one row of images which would mean that this issue is fixed starting with 3.0.0

@krabina

This comment has been minimized.

Copy link
Contributor

@krabina krabina commented Dec 16, 2018

This is what I see in Firefox and Chrome
grafik

@krabina

This comment has been minimized.

Copy link
Contributor

@krabina krabina commented Dec 16, 2018

If you switch the has caption printout with the next one, still the picture is shown in the second row, overlapping whatever printout there should be. So it has nothing to do with the "has caption" property.

@kghbln

This comment has been minimized.

Copy link
Member

@kghbln kghbln commented Dec 16, 2018

I see this:

image

Did you refresh the view by clicking the update button on the top right of the table?

@krabina

This comment has been minimized.

Copy link
Contributor

@krabina krabina commented Dec 16, 2018

refresh button does not change it in chrome, in FF i don't see those buttons:
grafik
I am working in Windows 10,, btw

@kghbln

This comment has been minimized.

Copy link
Member

@kghbln kghbln commented Dec 16, 2018

Ok, we have tracked it down. On Linux which I am using Fx is ok and Ch still shows the erroneous behaviour. However in both cases I see the update button on the top right as you can see in the screenshot. This is a second issue obviously only for Windows users.

@krabina

This comment has been minimized.

Copy link
Contributor

@krabina krabina commented Mar 27, 2019

any updates on this?
I gave datatables another try and encountered the next problem. A property of type boolean displays "t" "f" (true/false) even if you set #ja,nein
You can see it here: https://sandbox.semantic-mediawiki.org/wiki/Issue/1580

@krabina

This comment has been minimized.

Copy link
Contributor

@krabina krabina commented Mar 27, 2019

@mwjames

This comment has been minimized.

Copy link
Contributor

@mwjames mwjames commented Mar 30, 2019

any updates on this?

No.

PS: I don't want to sound like a broken record but as long as people don't make a contribution to an issue it is fairly unlikely a core member will come to its rescue. Open source means open to those willing to participate, add new feature, or fix bugs. Open doesn't mean only open to core members! Core members will help and support participants to maintain and retain a quality standard so that the software endures a maintainable state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.