Skip to content
This repository has been archived by the owner on Dec 21, 2018. It is now read-only.

Restore foreignNames for the AllCards file #78

Closed
Sembiance opened this issue Oct 1, 2015 · 5 comments
Closed

Restore foreignNames for the AllCards file #78

Sembiance opened this issue Oct 1, 2015 · 5 comments
Assignees

Comments

@Sembiance
Copy link
Contributor

The 'foreignNames' field was changed in 3.0.0 to only be present and only include data for that specific set (prior to this it was identical for every card in every set, see Issue #12 )

For the 'AllCards' files however, it probably makes sense to restore the 'foreignNames' field so that it includes all available languages for the card, regardless of set, since the AllCards files don't care about sets. Right now this field is entirely missing

@bra1n
Copy link
Contributor

bra1n commented Jan 19, 2016

Any news on this? :)

@phrozen
Copy link

phrozen commented Jan 20, 2016

I miss this field the most, I understand that foreignFields include the multiverseID of the card in the foreign language and that AllCards must not care about each set, but it should really have the possible names included. AllCards is said to be "quick and easy way to get basic card data" I really think that the card name is the most basic data one should have, and translations are really important.

@lsmoura lsmoura self-assigned this Jan 20, 2016
@lsmoura
Copy link
Contributor

lsmoura commented Jan 20, 2016

I'll get into it, guys. I still need a couple of weeks tough. I'll need to rewrite the generate.js file altogether and this will be implemented in the rewrite.

@ynerant
Copy link
Contributor

ynerant commented Jan 24, 2016

A couple of weeks ? Will it be possible to put an update of all of the sets before, with all of your modifications ? It'll can help me with my app ...

@ZeldaZach
Copy link
Member

Addressed in V4 :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants