Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS: false positive: `yield import blah` #1105

Closed
Trott opened this Issue Mar 13, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@Trott
Copy link

Trott commented Mar 13, 2019

Following up on https://discuss.lgtm.com/t/false-positive-yield-import-results-in-syntax-error/1883/2 which frustratingly I am unable to post to. (I opened the issue, got a reply with a question, posted my reply to the question, but got told by the interface that my reply would not appear until it was approved by an owner or moderator or staff member or whatever, and then got another reply prodding me to please answer the question I already answered but which apparently will sit in a moderator queue for who-knows-how-long. And now the interface doesn't even offer the option of replying. Fortunately, the last reply included a link to this repo so here we are...)

My original report:

lgtm flags yield import blah as a Syntax Error https://lgtm.com/rules/1800086/ 2. Perhaps lgtm is using acorn-dynamic-imports prior to 2.0.2?

lgtm staff reply:

could you provide a link to the project in question please?

My reply which never got posted:

https://lgtm.com/projects/g/ilios/frontend/snapshot/dist-1507417986286-1552400119401/files/app/components/programyear-objective-list.js?sort=name&dir=ASC&mode=heatmap#xa9a0de30b91adc3e:1

Thanks!

@xiemaisi xiemaisi self-assigned this Mar 13, 2019

@samlanning samlanning added the JS label Mar 13, 2019

@samlanning samlanning changed the title false positive: JavaScript `yield import blah` JS: false positive: `yield import blah` Mar 13, 2019

@samlanning

This comment has been minimized.

Copy link
Member

samlanning commented Mar 13, 2019

@Trott thanks for posting further information and opening an issue here.

Not sure what's happening w.r.t. you being unable to reply (discourse (the software that powers the forum) does some weird stuff when people include links to things etc...) but i'll look into it!

@xiemaisi

This comment has been minimized.

Copy link
Contributor

xiemaisi commented Mar 14, 2019

Thanks again for reporting this problem. A fix has been merged and should be deployed as part of the next LGTM.com upgrade within the next two weeks or so.

@xiemaisi

This comment has been minimized.

Copy link
Contributor

xiemaisi commented Mar 25, 2019

The fix has been deployed.

@xiemaisi xiemaisi closed this Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.