computation of attribute distances incorrect #20

Closed
FreakyBytes opened this Issue Jan 30, 2017 · 0 comments

Comments

Projects
None yet
1 participant
Owner

FreakyBytes commented Jan 30, 2017

Trac Ticket #20

component: code
owner: martin
reporter: martin
created: 2014-05-09 08:05:21
milestone:
type: task
version:
keywords:

the distance seems to be wrong, the computation has some problems with equality?

comment 1

time: 2014-05-09 08:08:33
author: martin

might be related to the move to jdom? /5af1f1e

comment 2

time: 2014-05-09 08:14:35
author: martin

indeed caused by /5af1f1e
in /src/main/java/de/unirostock/sems/xmlutils/ds/DocumentNode.java@5af1f1e#L636 we compare attribute objects, not their values... -> never equal -> distance always 1 as soon as there are attributes...

comment 3

time: 2014-08-04 13:54:19
author: Martin Scharm martin@binfalse.de

In None:


patched comparison of attributes [fixes #20]

before changeset:5af1f1e attributes map was a simple key-value map
so comparison of values was fine. but now the values are attribute
objects -> comparision of these objects is not what we intended

comment 4

time: 2014-08-04 13:54:19
author: Martin Scharm martin@binfalse.de

Updated resolution to fixed

comment 5

time: 2014-08-04 13:54:19
author: Martin Scharm martin@binfalse.de

Updated status to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment