Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running both ESLint and Jest together #67

Closed
ImmutableBox opened this issue Nov 7, 2019 · 2 comments
Closed

Running both ESLint and Jest together #67

ImmutableBox opened this issue Nov 7, 2019 · 2 comments
Assignees
Projects

Comments

@ImmutableBox
Copy link
Collaborator

@ImmutableBox ImmutableBox commented Nov 7, 2019

Currently ESLint and Jest is run by using different commands:
npm run eslint
npm run eslint-fix
npm run jest

Would be nice that have something like a prescript as @UltimaBGD suggested to run these commands.

More information/options:


@humphd :
the && operator won't work on all shells (e.g., many Windows shells). There are few work arounds for this:

  1. we can use pre and post scripts to run things before/after other steps, https://docs.npmjs.com/misc/scripts
  2. we could use https://www.npmjs.com/package/npm-run-all to allow for a set of steps

In general, we have to be careful that our scripts work on Windows, since so many common tricks like this will fail :(


@Reza-Rajabi Reza-Rajabi added this to Issue in Main via automation Nov 7, 2019
@UltimaBGD

This comment has been minimized.

Copy link
Contributor

@UltimaBGD UltimaBGD commented Nov 7, 2019

I'll get something up really quick.

@Reza-Rajabi Reza-Rajabi moved this from Issue to In progress/Review in Main Nov 7, 2019
@UltimaBGD

This comment has been minimized.

Copy link
Contributor

@UltimaBGD UltimaBGD commented Nov 7, 2019

This was worked on and merged via #69.

@UltimaBGD UltimaBGD closed this Nov 7, 2019
Main automation moved this from In progress/Review to Closed Nov 7, 2019
@Reza-Rajabi Reza-Rajabi added the on-board label Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Main
Closed
3 participants
You can’t perform that action at this time.