Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix (planet.css): changed custom class #140

Merged
merged 1 commit into from Nov 11, 2019

Conversation

ODAVING
Copy link
Contributor

@ODAVING ODAVING commented Nov 11, 2019

h1c was converted from custom tag to custom class to ensure HTML5 std

fixes #117

@humphd humphd changed the title bigfix (planet.css): changed custom class bugfix (planet.css): changed custom class Nov 11, 2019
h1c was converted from custom tag to custom class to ensure HTML5 std

fixes Seneca-CDOT#117
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this fixes our CI test runs. Thanks for fixing.

@ODAVING
Copy link
Contributor Author

ODAVING commented Nov 11, 2019

Awesome, this fixes our CI test runs. Thanks for fixing.

Pleasure! I was changing the title as you approved 😆

@humphd
Copy link
Contributor

humphd commented Nov 11, 2019

Get another reviewer to look at this, and it's good to land.

Copy link
Contributor

@MusaBajwa MusaBajwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Sina

@MusaBajwa MusaBajwa merged commit 994a471 into Seneca-CDOT:master Nov 11, 2019
Copy link
Contributor

@jerryshueh jerryshueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clear from my end @ODAVING!

@Reza-Rajabi Reza-Rajabi added this to In progress/Review in Main via automation Nov 13, 2019
@Reza-Rajabi Reza-Rajabi moved this from In progress/Review to Done in Main Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Main
Done
Development

Successfully merging this pull request may close these issues.

Invalid CSS selector in planet.css
5 participants