Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #45: Add CircleCI support #154

Merged
merged 7 commits into from Nov 14, 2019
Merged

Fix #45: Add CircleCI support #154

merged 7 commits into from Nov 14, 2019

Conversation

@sukhbeersingh
Copy link
Collaborator

sukhbeersingh commented Nov 12, 2019

This PR fixes #45 by adding a basic config.yml file that does the following:

1. Run node as the main container for build
2. Run docker image of redis, as a service container
3. Install dependencies, build and test

To test the code, you'll have to signup with CircleCI. Put the .circleci folder contents in your remote repo.

Go to the Projects page in the CircleCI app, click the Add Projects button, then click the Set Up Project button next to your project. If you don’t see your project, make sure you have selected the associated Org. See the Org Switching section below for tips.

Click the Start Building button to trigger your first build.

Referenced from https://circleci.com/docs/2.0/hello-world/

I think CDOT's account is signed up for CircleCI. @humphd can you please add this project for CI in CircleCI's jobs for CDOT?

(Hopefully this one gets merged

@humphd

This comment has been minimized.

Copy link
Contributor

humphd commented Nov 12, 2019

@kartik-budhiraja would you be willing to review this, since you did the Travis one?

@Reza-Rajabi Reza-Rajabi added this to In progress/Review in Main via automation Nov 13, 2019
@kartik-budhiraja kartik-budhiraja self-requested a review Nov 13, 2019
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@sukhbeersingh sukhbeersingh requested a review from kartik-budhiraja Nov 14, 2019
Copy link
Contributor

kartik-budhiraja left a comment

LGTM, great job @sukhbeersingh! Let's get this landed and get the circleCI pipeline up and running.

@sukhbeersingh

This comment has been minimized.

Copy link
Collaborator Author

sukhbeersingh commented Nov 14, 2019

@Reza-Rajabi would you please review as well, since you were primarily going to work on this issue?

@sukhbeersingh sukhbeersingh requested a review from Reza-Rajabi Nov 14, 2019
@humphd

This comment has been minimized.

Copy link
Contributor

humphd commented Nov 14, 2019

I have enabled Circle CI for this repo, see https://circleci.com/gh/Seneca-CDOT/telescope

.circleci/config.yml Outdated Show resolved Hide resolved
@humphd
humphd approved these changes Nov 14, 2019
@cindyledev cindyledev self-requested a review Nov 14, 2019
@manekenpix manekenpix self-requested a review Nov 14, 2019
Copy link
Collaborator

manekenpix left a comment

Awesome!

@humphd humphd merged commit 36ab909 into Seneca-CDOT:master Nov 14, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Main automation moved this from In progress/Review to Done Nov 14, 2019
@humphd humphd changed the title Fix 45: Add CircleCI support Fix #45: Add CircleCI support Nov 14, 2019
@sukhbeersingh sukhbeersingh deleted the sukhbeersingh:issue45 branch Nov 14, 2019
@Reza-Rajabi

This comment has been minimized.

Copy link
Collaborator

Reza-Rajabi commented Nov 15, 2019

@Reza-Rajabi would you please review as well, since you were primarily going to work on this issue?

@sukhbeersingh sorry for missing that. Hopefully this one got merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Main
Done
6 participants
You can’t perform that action at this time.