Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #153 - New front-end structure & design #180

Merged
merged 2 commits into from Nov 14, 2019

Conversation

@lucacataldo
Copy link
Collaborator

lucacataldo commented Nov 14, 2019

Fixes #153

This pull request introduces a new front end design and structure that builds on what @ODAVING had created using the old Planet structure and the design mockups created in #12 . The new design is responsive and uses CSS grid to allow for easier maintenance down the line. It also features a cleaner HTML structure and includes an easily template-able

tag as the basis for each blog post. A small UX tweak I added was to sticky the "Title" section of each article to the top while scrolling since a major gripe of mine when using the old Planet was that it was difficult to know which article you were reading when scrolling through a wall of text.

Obviously this UI is still feature-light but I hope that it is a starting point that we can use going forward as we add to it. Eg: Pagination, search, post stats, etc.

You can view the live demo here

Screenshot:
image

In this PR I also removed some old, unused files like the planet.css & images folder that was found in the root dir. I also used a temporary logo.svg I created until the logo PR gets merged / resolved.

Some other

Luca Cataldo
Prepared HTML for templating
Included temporary logo
Removed unused images in root dir
@manekenpix manekenpix added this to In progress/Review in Main via automation Nov 14, 2019
Copy link
Collaborator

cagomezr left a comment

The system seems to be working fine Im not ok with white space of the sidebar in responsive but I think if we work on it on next iteration this will be fantastic.

src/frontend/style/main.css Outdated Show resolved Hide resolved
Luca Cataldo
@manekenpix manekenpix self-requested a review Nov 14, 2019
Copy link
Collaborator

manekenpix left a comment

Looking good! 👍

@cagomezr cagomezr merged commit 582d681 into Seneca-CDOT:master Nov 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Main automation moved this from In progress/Review to Done Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Main
Done
3 participants
You can’t perform that action at this time.