Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #108: integrate feed parser with feed worker #195

Merged
merged 3 commits into from Nov 15, 2019
Merged

Fix #108: integrate feed parser with feed worker #195

merged 3 commits into from Nov 15, 2019

Conversation

@jayson528
Copy link
Contributor

jayson528 commented Nov 14, 2019

updated function to return an array of "processed" post objects.

jayson528 added 2 commits Nov 14, 2019
@jayson528 jayson528 requested a review from manekenpix Nov 14, 2019
@humphd humphd changed the title Issue#108 Fix #108: integrate feed parser with feed worker Nov 15, 2019
processedPosts.push(processedPost);
});
}
return processedPosts;

This comment has been minimized.

Copy link
@humphd

humphd Nov 15, 2019

Contributor

You can't really return anything here. You're deep inside an async call that's working on processing URLs. What we'll really need to do is feed these into another queue for analysis.

Can you just log something to the console instead? I know it's minor, but it will help other people see that it's working.

@humphd
humphd approved these changes Nov 15, 2019
@humphd humphd merged commit e7e6e6c into master Nov 15, 2019
3 checks passed
3 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@humphd humphd deleted the issue#108 branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.