Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for inactive blog checking (#197) #211

Merged
merged 4 commits into from Nov 15, 2019

Conversation

@Silvyre
Copy link
Collaborator

Silvyre commented Nov 15, 2019

This pull request adds testing for the check() function defined in inactive-blog-filter.js.

This pull request does not, however, cover testing for the update() function. As noted in #197 (comment), the creation of some testing environment, or some alteration of the update() function needs to be done to facilitate proper testing. I plan to continue looking into this, and plan to make a separate pull request when I come up with a solution.

@Silvyre Silvyre added the type: test label Nov 15, 2019
@Silvyre Silvyre requested review from jerryshueh, UltimaBGD, ODAVING and dbeigi Nov 15, 2019
@Silvyre Silvyre self-assigned this Nov 15, 2019
@manekenpix manekenpix added this to In progress/Review in Main via automation Nov 15, 2019
Silvyre added 2 commits Nov 15, 2019
test/inactive-blog-filter.test.js Outdated Show resolved Hide resolved
test/inactive-blog-filter.test.js Outdated Show resolved Hide resolved
test/inactive-blog-filter.test.js Outdated Show resolved Hide resolved
@Silvyre Silvyre requested a review from humphd Nov 15, 2019
@humphd
humphd approved these changes Nov 15, 2019
@humphd humphd merged commit af68e0a into master Nov 15, 2019
3 checks passed
3 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Main automation moved this from In progress/Review to Done Nov 15, 2019
@humphd humphd deleted the issue-197-inactive-blog-filter-tests branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.