Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#182 Adding travis compatibility for mac and windows #212

Merged
merged 60 commits into from Nov 16, 2019

Conversation

@Manan311
Copy link
Contributor

Manan311 commented Nov 15, 2019

Adding support for mac and windows.

Fix# 182

Manan311 and others added 14 commits Nov 15, 2019
Manan311
Manan311
Manan311
Manan311
Manan311
Manan311
@Manan311 Manan311 changed the title Fix#182 Adding travis compatibility for mac Fix#182 Adding travis compatibility for mac and windows Nov 15, 2019
jayson528 and others added 14 commits Nov 14, 2019
* fix 115 added test cases

* removed space at the end of file

* addressing check failures

* Fix #25: Implement basic email sender

* Async Function Promise and Env File

* Travis CI Fix

* Travis CI

* Travis CI Fix

* Comments

* Implement SMTP

* Circle Ci Changes

* package.json conflict

* info.accepted

* rework on test cases
* Added testing for inactive blog checking (#197)

* Update 5b724a0 to address ci testing

* Specify encoding for readFileSync

* Address review comments
@Manan311

This comment has been minimized.

Copy link
Contributor Author

Manan311 commented Nov 15, 2019

Duplicate of #188?

Yes, I closed the other pr and gonna be working on this one.

@Manan311 Manan311 requested review from MusaBajwa and wajeehsheikh Nov 15, 2019
Copy link
Contributor

MusaBajwa left a comment

Passed the test looks good to me.

Copy link
Contributor

wajeehsheikh left a comment

good job!

@Manan311 Manan311 merged commit 465ff14 into Seneca-CDOT:master Nov 16, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
ci/circleci: build Your tests passed on CircleCI!
Details
@Manan311 Manan311 deleted the Manan311:issue-182 branch Nov 16, 2019
@humphd

This comment has been minimized.

Copy link
Contributor

humphd commented Nov 16, 2019

Looks like this got merged, but it fails to build on Mac and Windows:

https://travis-ci.org/Seneca-CDOT/telescope/builds/612670221

We shouldn't have merged until that was working. I'll file a follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.